[FFmpeg-devel] [PATCH] check validity of --list-* parameter

[Måns Rullgård]

Aurelien Jacobs <aurel at gnuage.org> writes:

> Hi,
>
> Attached patch ensure that configure will reject parameters such as
> --list-have or --list-foobar. It fixes issue72.
> Note that COMPONENT_LIST and is_in can be used to simplify other
> part of configure (I will probably propose some patches after this
> one is applied).
>
> Aurel
>
> Index: configure
> ===================================================================
> --- configure	(r??vision 10131)
> +++ configure	(copie de travail)
> @@ -291,6 +291,15 @@
>      done
>  }
>  
> +is_in(){
> +    value=$1
> +    shift
> +    for var in $*; do
> +        [ $var = $value ] && return 0
> +    done
> +    return 1
> +}
> +
>  check_deps(){
>      for cfg; do
>          enabled ${cfg}_checking && die "Circular dependency for $cfg."
> @@ -567,18 +576,25 @@
>      "$@" < "$file" > "$file.tmp" && mv "$file.tmp" "$file" || rm "$file.tmp"
>  }
>  
> -CONFIG_LIST='
> +COMPONENT_LIST="
> +    bsfs
> +    decoders
> +    demuxers
> +    encoders
> +    muxers
> +    parsers
> +    protocols
> +"

I don't think COMPONENT is a very good name for this list.

Other than that, I have no comments.

-- 
M?ns Rullg?rd
mans at mansr.com