[FFmpeg-devel] [PATCH] SPARC VIS simple_idct try#6

Michael Niedermayer michaelni
Wed Aug 29 00:13:20 CEST 2007


Hi

On Tue, Aug 28, 2007 at 10:38:23PM +0200, Balatoni Denes wrote:
> Hi!
> 
> I forgot...
> 
> Tuesday 28 August 2007 22:31-kor Balatoni Denes ezt ?rta:
> > > you are forgetting that theres also 25% between the horizontal and
> > > vertical idcts which can be reused with no store/load and no changes to
> > > the registers
> >
> > Indeed, I didn't take that into account. So if I fix that 25% and the
> > clamping part, will you accept the patch?
> 
> Better yet: that would be 4 instructions. How about I gain 4 clocks in some 
> other way instead - how, let it be my secret. Okay?

hmm no but you have to do that secret optimization too now at minimum for it
to be considered for svn

let me remind you, code has to be optimal to be accepted

ill investigate the register shortage vs. avoidable load/stores vs. latency
after (the unlikely) case that you do correct the undisputed suboptimalities

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070829/107addc8/attachment.pgp>



More information about the ffmpeg-devel mailing list