[FFmpeg-devel] [PATCH] Matroska Muxer
Thu Aug 30 10:30:46 CEST 2007
On Thu, Aug 30, 2007 at 12:10:24AM -0400, David Conrad wrote:
> New patch attached, with regression tests updated.
Documentation and build system parts are OK, I'm not sure if I already
Some unimportant nits below.
> --- /dev/null
> +++ b/libavformat/matroskaenc.c
> @@ -0,0 +1,828 @@
> + * Write an EBML size meaning "unknown size"
> + * @param segment_offset The absolute offset to the position in the file
> + * where the segment begins
> + * @param numelements the maximum number of elements that will be indexed
> + * @return the file offset where the seekhead was written
> + av_log(s, AV_LOG_WARNING, "no AAC extradata, unable to determine samplerate\n");
> + av_log(s, AV_LOG_ERROR, "no bmp codec id found");
Ditto, and I'd write "ID".
> + av_log(s, AV_LOG_ERROR, "no wav codec id found");
There are some more instances of lowercase ID, I prefer uppercase. Feel
free to ignore me.
Overall this is looking good. I expect your muxer to become an official
part of FFmpeg soon.
More information about the ffmpeg-devel