[FFmpeg-devel] [PATCH] snow SSE2 add_yblock

Michael Niedermayer michaelni
Fri Aug 31 05:04:44 CEST 2007


On Fri, Aug 31, 2007 at 02:57:05AM +0200, Reimar D?ffinger wrote:
> Hello,
> On Thu, Aug 30, 2007 at 06:19:49PM +0200, Michael Niedermayer wrote:
> > On Thu, Aug 30, 2007 at 04:56:41PM +0200, Reimar D?ffinger wrote:
> > > attached patch should have a working version.
> > > I have replaced several of the hardcoded registers by something more
> > > flexible because I found it also nicer to read.
> > > Suggestions welcome (though optimizations IMO should be done after
> > > applying and reenabling).
> > > And better don't try to read the patch but apply and read the resulting
> > > asm, diff made something quite butchered out of this.
> > 
> > while iam glad that you fix the bugs, cleanup the code and all,
> > this really doesnt belong in a single patch
> Well, I considered it a replacing of the old code. If you consider it
> bugfix and improvements of the current code I guess not.
> Splitting it properly will involve loads of patches. I can do that
> eventually, but it will take some time and involve quite a few
> cosmetic/not so useful patches (also since I don't remember for sure for
> all cases why I did them like this).

i dont think it requires that many patches
its just fix bugs (1-2 patches)
rewrite (cosmetic) same object files generated (1 patch)


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070831/0b1724a7/attachment.pgp>

More information about the ffmpeg-devel mailing list