[FFmpeg-devel] [PATCH] Don't let ctx->skip_frame>0 produce errors

[Michael Niedermayer]

Hi

On Thu, Aug 30, 2007 at 10:51:16PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> On 2007-08-30 19:16, Carl Eugen Hoyos wrote:
> [...]
> 
> > > > > well but what if
> > > > > avctx->skip_frame>0
> > > > > and this code is reached for a reason different then skip_frame ?
> > > >
> > > > Then the user silenced an error by disabling complete decoding.
> > > > Or is there a better solution? More different return values for
> > > > decode_nal_units() only make the code messier, don't you think?
> > > 
> > > also
> > > if( (s->hurry_up == 1 && h->nal_ref_idc == 0) //FIXME do not discard SEI id
> > > ||(avctx->skip_frame >= AVDISCARD_NONREF && h->nal_ref_idc == 0))
> > > continue;
> > >
> > > your code hides the warning only in one of the 2 cases
> > 
> > I was under the obviously wrong impression that deprecated features are
> > not considered when doing such a change.

well, until they are removed i think we should not intentional "mess"
them up


> 
> And now a hopefully fixed version, Carl Eugen

patch ok, though iam not entirely happy with the solution

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070831/34899583/attachment.pgp>