[FFmpeg-devel] [FFmpeg-cvslog] r11100 - in trunk/libavcodec/i386: cavsdsp_mmx.c dsputil_mmx.c dsputil_mmx.h h264dsp_mmx.c mpegvideo_mmx.c vc1dsp_mmx.c

Michael Niedermayer michaelni
Sat Dec 1 02:42:44 CET 2007

On Sat, Dec 01, 2007 at 02:00:57AM +0200, Uoti Urpala wrote:
> On Fri, 2007-11-30 at 21:11 +0100, Michael Niedermayer wrote:
> > On Fri, Nov 30, 2007 at 07:04:42PM +0200, Uoti Urpala wrote:
> > > Any linker stuff like (3) or (4) cannot give the full available
> > speedup;
> > 
> > yes, but adding -Bsymbolic to ld is easy, getting the vissibility correct
> > migh not be, i dunno, iam happy with a clean patch which fixes the vissibility
> > of symbols to the minimum overrideable and vissible as well
> > still i think (3) is simpler ...
> Getting visibility correct is very straightforward and obvious if you do
> it per symbol, but requires a code change for each symbol whose
> visibility you want to change. Basically you'd have 'static' for things
> visible only in the same translation unit, and 'FF_PRIVATE' (or some
> better macro name) for things visible only in the same library. 

i know that, the problems are
1. the amount of symbols
2. its often not completely clear if something should or should not be
   vissible from the outside

> Pragmas
> allow getting the result with much fewer code changes but result in less
> obvious code.

> -Bsymbolic is "simpler" of course but it does not achieve the same
> things.

it fixes the link failure which is the orignal issue and that has to be
fixed, waiting several month for any per symbol work just is no alternative
no matter if or if not its a good idea on its own


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071201/5587f6a7/attachment.pgp>

More information about the ffmpeg-devel mailing list