[FFmpeg-devel] flac_compute_autocorr_sse2 not pic-safe

[Edward Hervey]

On Tue, 2007-12-04 at 18:56 +0100, Michael Niedermayer wrote:
> On Tue, Dec 04, 2007 at 03:27:18PM +0100, Edward Hervey wrote:
> > Hi all,
> > 
> >   While compiling ffmpeg as static library to be put into a shared
> > library (./configure --enable-static --disable-shared
> > --extra-cflags=-fPIC), I encountered a piece of asm code which isn't
> > PIC-safe.
> > 
> >   The proposed patch disables that optimized routine when the
> > configuration doesn't allow it (HAVE_7REGS set to 1).
> 
> patch rejected, this code does not need 7 registers

I do see 7 being used in the clobber list though (dsputil.c line 3064):

[...]
                :"+&r"(i), "=m"(autoc[j]), "=m"(autoc[j+1]),
"=m"(autoc[j+2])
                :"r"(data1+len), "r"(data1+len-j), "m"(*ff_pd_1)
[...]

> 
> [...]
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel