[FFmpeg-devel] [PATCH] Alternative OS/2 patch

Diego Biurrun diego
Thu Dec 6 00:14:41 CET 2007


On Wed, Dec 05, 2007 at 01:05:40PM -0800, Dave Yeo wrote:
> On 12/05/07 02:34 am, Diego Biurrun wrote:
>> On Mon, Dec 03, 2007 at 10:38:02PM -0800, Dave Yeo wrote:
>>> On 11/27/07 02:34 am, Diego Biurrun wrote:
>>>> On Mon, Nov 26, 2007 at 06:11:54PM -0800, Dave Yeo wrote:
>>> --- configure	(revision 11160)
>>> +++ configure	(working copy)
>>> @@ -1219,6 +1221,35 @@
>>> +    os/2*)
>>> +        LIBSUF="_s.lib"
>>> +        SLIBPREF=""
>>> +        SLIBSUF=".dll"
>>> +        SLIBNAME_WITH_VERSION='$(SLIBPREF)$(NAME)-$(LIBVERSION)$(SLIBSUF)'
>>> +        SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(shell echo $(NAME) | cut -c1-6)$(LIBMAJOR)$(SLIBSUF)'
>> WTF ?
>
> The previous patch would break with introduction of libosspupport. Fix is 
> to truncate the DLL name to 8 chars. This way we cut the name to 6 chars 
> and add the major version number to it therefore giving a versioned DLL. 
> This seemed the simplest method without introducing new variables etc. I'm 
> open to other ideas.

I have no thoughts on this apart from a firm resolve not to touch OS/2.
Oh, the ugliness of 8+3 filenames ...

Anyway, patch applied.

Diego




More information about the ffmpeg-devel mailing list