[FFmpeg-devel] [PATCH] let ac3dec.c use request_channels

Andreas Öman andreas
Thu Dec 13 07:53:27 CET 2007


Justin Ruggles wrote:
> I'm pretty sure this should be:
> if (avctx->requested_channels > ctx->channels ||
> (avctx->requested_channels != ctx->channels &&
> avctx->requested_channels > 2))
> Because it doesn't matter if requested_channels is more than 2 if it 
> matches the number of source channels.  The way you have it, you could 
> get something like "Cannot mix AC3 from 6 to 6 channels."

Yeah. I'm going to rewrite this patch anyway since the general idea now
is that we should never fail if the request_channels request cannot be

I'll be back...

More information about the ffmpeg-devel mailing list