[FFmpeg-devel] [PATCH][0/4]: MMS base and MMSH implementation

Michael Niedermayer michaelni
Thu Dec 13 23:03:46 CET 2007

On Thu, Dec 13, 2007 at 04:29:26PM +0100, Bj?rn Axelsson wrote:
> On Thu, 2007-11-29 at 11:00 +0100, Bj?rn Axelsson wrote:
> > This is basically the same as my old MMS patch, only somewhat updated
> > and split into smaller patches (one per file).
> > 
> > Patch 1 and 2 are only new files and can be applied in any order.
> > Patch 3 depends on 1 and 2, but still only touches the new files.
> > The fourth patch in this series contains the makefile changes and
> > protocol registration code, and should not be applied before the other
> > three are applied. Only when this patch is applied can the new code  be
> > compiled and used.
> > 
> > The complete series passes "make test".
> Ping?
> This has hasn't been reviewed in two weeks. Please let me know if I can
> do anything more to help.

spliting the patch per files, (it seems thats what you did) does not help
me review it actually it makes it harder, what would help is split it
in some self contained way

a totally hypothetical and probably not applicable variant would be
1. a patch for just establishing the connection
2. a patch for reading packets
3. a patch which adds seeking
4. a patch which adds pause support
5. a patch which adds support to send back connection statistics to the servr

in the above 1/1+2/1+2+3/.. must of corse be applyable without breaking
ffmpeg and 1 must not contain anything not needed for 1 itself, ...

anyway ill review the patches you posted eventually, iam just reviewing
smaller/simpler patches first


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071213/735cda94/attachment.pgp>

More information about the ffmpeg-devel mailing list