[FFmpeg-devel] [PATCH] Export MANGLE definition

Reimar Döffinger Reimar.Doeffinger
Sat Dec 15 19:06:05 CET 2007

On Sat, Dec 15, 2007 at 07:38:36PM +0200, Uoti Urpala wrote:
> On Sat, 2007-12-15 at 10:03 +0100, Reimar D?ffinger wrote:
> > On Fri, Dec 14, 2007 at 10:10:57PM +0200, Uoti Urpala wrote:
> > > There should be no need to use it. Generally the places which use MANGLE
> > > should use asm arguments instead.
> > 
> > In theory. I tested back then when I tried to compile with ICC, the end
> > result was that neither ICC nor gcc could compile it because they
> > thought they needed like 12 registers. I think it was gcc 3.3 back then,
> > but I am not sure. ICC was version 9. Unless I was actually testing the
> > Sun compiler not ICC...
> Which "it" did they fail to compile? I posted an improved version of
> cabac.h asm a while ago that did not use MANGLE, and it was tested to
> work with gcc 4.1 and 4.2 at least. I haven't tried similar cleanup with
> every piece of asm in FFmpeg of course...

It was some dsputil stuff. I'm sorry, I didn't write it down.
If someone makes a patch to change it I'd happily test it on a few
different compilers (though I admit I don't even have a gcc 3.3 here
anymore, since it was buggy in other aspects as well).
Are there any other obvious disadvantages to changing it?

Reimar D?ffinger

More information about the ffmpeg-devel mailing list