[FFmpeg-devel] [PATCH] don't set is_streamed when it's not

Aurelien Jacobs aurel
Thu Dec 20 01:38:10 CET 2007

Michael Niedermayer wrote:

> On Thu, Dec 20, 2007 at 12:38:14AM +0100, Aurelien Jacobs wrote:
> > Hi,
> > 
> > Currently ffserver uses url_open_buf() and url_open_dyn_buf() and
> > then set is_streamed in the resulting ByteIOContext.
> > This seems plain wrong. Buffers are really not streamed.
> > Attached patch avoid this. OK ?
> hmm, i dont think so
> Its surely true that the buffer in which the header is written is
> seekable. But the packets following are not that is we cant seek back
> and update the header, this would cause problems as muxers would
> think during header writing that they could seek back later and
> update things ...

OK. I now understand why is_streamed is needed here.
So I guess the right way to avoid direct access to ByteIOContext
internals here is to add a url_set_streamed() function to the API ?
Is attached patch OK ?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bio_set_streamed.diff
Type: text/x-patch
Size: 1612 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071220/eb06132b/attachment.bin>

More information about the ffmpeg-devel mailing list