Sat Dec 22 13:34:55 CET 2007
Please remove from mailing list.> Date: Sat, 22 Dec 2007 01:11:47 +0100> From: michaelni at gmx.at> To: ffmpeg-devel at mplayerhq.hu> Subject: Re: [FFmpeg-devel] [PATCH] don't set is_streamed when it's not> > On Sat, Dec 22, 2007 at 12:36:45AM +0100, Aurelien Jacobs wrote:> > Michael Niedermayer wrote:> [...]> > > > > Just look at:> > > > > /* XXX: put an inline version */> > > > > int get_byte(ByteIOContext *s)> > > > > > > > > > If that XXX is done> > > > > > > > It is not. That's a non-issue right now.> > > > > > Well ...> > > I dont like changes which would need to be reverted in the future ...> > > > I don't like refusing changes only because it might eventually> > require to be changed again in a distant future.> > > > > > > Iam in favor of preventing misuse were it can be done easily and> > > > > cleanly in case of ByteIOContext though i dont think that set/get> > > > > functions for most fields are a good idea. And its not just> > > > > set_is_streamed() but also the ones existing already as well ...> > > > > > > > Which existing ones ? init_put_byte() ? (Which is basically a> > > > set_everything_but_the_new_fields_added_after_this_function())> > > > > > url_is_streamed()> > > url_feof()> > > url_ferror()> > > url_fileno()> > > url_fget_max_packet_size()> > > > Just to be clear, do you propose to remove them ? (at least with> > next major version bump)> > Hmm, i would not mind removing them.> > [...]> -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB> > Breaking DRM is a little like attempting to break through a door even> though the window is wide open and the only thing in the house is a bunch> of things you dont want and which you would get tomorrow for free anyway
Microsoft vous offre un logiciel pour classer, retoucher et partager vos photos !
More information about the ffmpeg-devel