[FFmpeg-devel] libossupport status

Rich Felker dalias
Sun Dec 23 11:55:22 CET 2007

On Sat, Dec 22, 2007 at 11:42:28PM +0100, Vadim Lebedev wrote:
> I agree,
> But it seems that original message in this thread suggest different 
> approach:  The patch for example proposes
> to remove #include "os_support.h" and
> to replace:
>     ff_socket_nonblock(server_fd, 1);
> by:
>     fcntl(server_fd, F_SETFL, fcntl(server_fd, F_GETFL) | O_NONBLOCK);
> This will no work on win32 (there is no F_SETFL on WIN32)

Then add it. Submit patches to mingw for their broken crap, and then
require latest mingw...

Anyway WTF is the point of this? O_NONBLOCK is useless; just do a
select before attempting to read/write... Or are you worried about
running into the Linux bug in select? :)

> The best way IMO will be to keep evrywhere
> #include "os_support.h" 

No this is absolutely disgusting and unnecessary. The idea of "loss"
is to be a no-op for non-broken operating systems, not to pollute
everywhere with windows-workaround crap.


More information about the ffmpeg-devel mailing list