[FFmpeg-devel] [PATCH] PC Paintbrush PCX decoder

Ivo ivop
Wed Dec 26 17:02:56 CET 2007


On Wednesday 26 December 2007 16:54, Ivo wrote:
> On Wednesday 26 December 2007 14:50, Michael Niedermayer wrote:
> > On Tue, Dec 25, 2007 at 01:45:06PM +0100, Ivo wrote:
> > > +    avcodec_get_frame_defaults((AVFrame*)&s->picture);
> > > +    avctx->coded_frame= (AVFrame*)&s->picture;
> >
> > what are these casts doing?
>
> No idea :) I copied that part from another decoder. There are quite some
> occurances of these lines in libavcodec. Anyway, I removed the casts,
>
> > > +    s->picture.data[0] = NULL;
> >
> > why?
>
> Same as above (copied from another decoder). Removed.

Forgot one instance of a useless cast. I also fixed the *picture= assignment 
later on and updated the Sun Rasterfile code.

--Ivo




More information about the ffmpeg-devel mailing list