[FFmpeg-devel] [PATCH] rtsp - alternate protocol

Luca Barbato lu_zero
Fri Dec 28 16:29:03 CET 2007


M?ns Rullg?rd wrote:
> Luca Barbato <lu_zero at gentoo.org> writes:
> 
>> Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> attached patch allows the rtsp module to retry with alternate protocols if
>>> the first try fails. This allows the default setup to work with both
>>> UDP-only and TCP-only servers, even if the default is set to the wrong one.
>>>
>> Could you try to use something different than a goto?
> 
> What's to complain about regarding that goto?

I don't like the way it is used here.

Ideally the best would be something that iterates over using a while.

That would make simpler and less cluttered add more transports later.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero





More information about the ffmpeg-devel mailing list