[FFmpeg-devel] [PATCH] rtsp - alternate protocol
Fri Dec 28 23:51:37 CET 2007
On Fri, Dec 28, 2007 at 11:12:54PM +0100, Luca Abeni wrote:
> Hi Ronald,
> Luca Abeni wrote:
> > Ronald S. Bultje wrote:
> > [...]
> >>> If I understand the code correctly, it is explicitly copying in path
> >>> only the part of the URL contained between "/" and "?".
> >>> Should it be fixed by removing the "strchr(p, '?')"? Wouldn't this break
> >>> something else?
> >> That sounds correct, I think you can commit that.
> > Uhmmm... That was my impression too... But this change would basically
> > reverse r10775, which claim to fix a regression. So, fixing a bug risks
> > to re-introduce an old regression... I need to investigate this issue a
> > little bit more.
> It seems that the situation is more messy than I expected:
> 1) url_split() has been rewritten in r10605
> 2) the rewrite introduced a regression, by changing the behaviour of
> 3) r10775 claimed to fix the regression by introducing yet another
> different behaviour in url_split(). And this is the change that broke
> option parsing in rtsp.c.
ive just approved r10775 because ronald said it restores original behavior
i even EXPLICITLY complained that ot would cut the ? part off
you can revert r10775 or any part of it as you see fit!
> Some data points:
> 1) Before r10605, rtsp://localhost:5454/test1-rtsp.mpg?tcp resulted in
> 2) After r10605, the same url produced path="/test1-rtsp.mpg?tcp", so no
> change for this test case...
> 3) r10775 "fixed" something so that the result is now
> 4) So, I tried a different url: rtsp://localhost?tcp. The results are
> path="?tcp" before r10605, path="" after r10605, and path="" after
> r10775. Again, that commit does not seem to fix any regression.
> So, can anyone explain what's the supposed behaviour of url_split()?
> Which testcase was fixed by r10775?
iam not sure but if i guess i think it prevents ?tcp from ending in the
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel