[FFmpeg-devel] [PATCH] rtsp - alternate protocol

Ronald S. Bultje rsbultje
Sat Dec 29 10:15:34 CET 2007


Hi,

On Dec 28, 2007 5:12 PM, Michael Niedermayer <michaelni at gmx.at> wrote:

> > @@ -978,6 +998,11 @@
> >                   "Transport: %s\r\n",
> >                   rtsp_st->control_url, transport);
> >          rtsp_send_cmd(s, cmd, reply, NULL);
> > +        if (reply->status_code == 461 /* Unsupported protocol */ && i
> == 0 &&
> > +            num_bits_set(protocol_mask) >= 2) {
> > +            protocol_mask = unset_lowest_bit(protocol_mask);
>
> > +            j = RTSP_RTP_PORT_MIN; i--; continue;
>
> NO, try to write clean code, please!
> or it will take till 2009 to get this into commitable shape


Well, for what looks easy to implement to me (= small patches), it's either
a goto (which people disliked) or this. Are there other ways to do this?

Ronald




More information about the ffmpeg-devel mailing list