[FFmpeg-devel] [PATCH] url_write not defined if muxers are disabled

Michael Niedermayer michaelni
Sun Dec 30 21:43:25 CET 2007

On Sun, Dec 23, 2007 at 08:47:21PM +0100, Gianluigi Tiesi wrote:
> Hi,
> I've noticed that url_write in avio.c is referenced even if
> muxers are not enabled, but it's not compiled in.
> The patch allows to return EIO if someone calls url_fopen/fdopen
> in write mode while muxers are disabled

patch rejected

This is a hack no solution, such a dummy function fixes compilation and
linking. If it works at runtime is dubious. You would have to proof that
all uses of url_write() are wrong and if they are few fix the uses to be
under #ifdef instead of giving them a dummy url_write().

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071230/5ba82cc7/attachment.pgp>

More information about the ffmpeg-devel mailing list