[Ffmpeg-devel] [PATCH]Export base64 functions

[Michael Niedermayer]

Hi

On Sun, Feb 04, 2007 at 07:19:38PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch is a try to export base64 functions so av_base64_decode()
> could be used inside MPlayer.
> 
> Please review, Carl Eugen
> 

> Index: libavformat/base64.c
> ===================================================================
> --- libavformat/base64.c	(Revision 7817)
> +++ libavformat/base64.c	(Arbeitskopie)
> @@ -26,7 +26,7 @@
>   */
>  
>  #include "common.h"
> -#include "base64.h"
> +#include "avformat.h"

base64 should rather be moved to libavutil as its a fairly general thing


>  
>  /* ---------------- private code */
>  static uint8_t map2[] =
> Index: libavformat/avformat.h
> ===================================================================
> --- libavformat/avformat.h	(Revision 7817)
> +++ libavformat/avformat.h	(Arbeitskopie)
> @@ -499,6 +499,10 @@
>  int dv1394_init(void);
>  int dc1394_init(void);
>  
> +/* base64.c */
> +int av_base64_decode(uint8_t * out, const char *in, int out_length);  // param order as strncpy()
> +char *av_base64_encode(uint8_t * src, int len);       // src is not a string, it's data.

not doxygen compatible comments
and iam not happy about the *malloc() dependancy in av_base64_encode()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070204/b15a0c92/attachment.pgp>