[Ffmpeg-devel] [PATCH] lowres chroma bug

Oleg Metelitsa oleg
Tue Feb 6 07:15:20 CET 2007


Hello,

Please find attached a patch, that solves an 
"extreme chroma bug" problem in lowres=2 mode
reported by Reimar Doffinger 6 months ago:
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-July/012550.html
http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/33781/focus=33811

I tested the patch in MPEG4 video decoding (CODEC_ID_MPEG4), 
green boxes are eliminated.

Is the proposed patch OK ?


Best regards,

Oleg Metelitsa


-------------- next part --------------
Index: libavcodec/i386/dsputil_h264_template_mmx.c
===================================================================


--- dsputil_h264_template_mmx.c (revision 7818)
+++ dsputil_h264_template_mmx.c (working copy)
@@ -317,8 +317,9 @@

             /* writes garbage to the right of dst.
              * ok because partitions are processed from left to right. */
             H264_CHROMA_OP4(%0, %%mm1, %%mm3)
-            "movd %%mm1, %0\n\t"
-            : "=m" (dst[0]) : "m" (ff_pw_32));
+            "movd %%mm1, %%edx\n\t"
+            "mov %%dx, %0\n\t"
+            : "=m" (dst[0]) : "m" (ff_pw_32): "%edx");
         dst += stride;
     }
 }


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel





More information about the ffmpeg-devel mailing list