[Ffmpeg-devel] [PATCH] Convert deprecated colorspace names

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Sun, Feb 11, 2007 at 02:06:39PM +0100, Baptiste Coudurier wrote:
>> Baptiste Coudurier wrote:
>>> Hi
>>>
>>> Diego Biurrun wrote:
>>>> On Wed, Feb 07, 2007 at 01:11:50AM +0100, Michael Niedermayer wrote:
>>>>> On Tue, Feb 06, 2007 at 10:39:39PM +0100, Diego Biurrun wrote:
>>>>>> Attached is a patch that addresses the change of colorspace names
>>>>>> performed in libavutil/avutil.h:
>>>>>>
>>>>>> #if LIBAVUTIL_VERSION_INT < (50<<16)
>>>>>> #define PIX_FMT_UYVY411 PIX_FMT_UYYVYY411
>>>>>> #define PIX_FMT_RGBA32  PIX_FMT_RGB32
>>>>>> #define PIX_FMT_YUV422  PIX_FMT_YUYV422
>>>>>> #endif
>>>>>>
>>>>>> OK to apply?
>>>>> yes
>>>> Done.
>>>>
>>> Btw, can we get rid of PIX_FMT_RGB32_1 ? Does that name have even a sense ?
>>>
>> Ping ?
> 
> timeout
> 
> 
>> Also it would be nice to uniform PIX_FMT so they not depend on cpu
>> endianness, 
> 
> did you even read the source?

yes

> there are endianness dependant and independant ones one mapped to the
> other depending cpu endianness
> so that code which works bytewise (=slow as hell) and code which reads
> 16/32bit wise can both simple check for a single pix_fmt

IMHO reference must be what is stored in the file, and not on which cpu
code will run. Routines must check during init, those #define are messy,
not talking about names like RGB32_1 which mean just nothing, that's
what I mean when I say "uniform".

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312