[Ffmpeg-devel] [RFC] [PATCH] FLC/FLX/DTA encoder

[Alex Beregszaszi]

Hi,

> > Known:
> > * current patch has hard tabs and maybe identation issues (but any
> > cosmetic recommendations are welcomed)
> 
> Why don't you do something about that?  You know what the rules are.

I'm removing hard tabs. Btw, there are extreme long lines in
encode_delta8(). That is a questionable part.

> > Question:
> > * should it be splitted into flicenc.c ?
> 
> Yes.  How different are FLC, FLX and DTA?  Perhaps even they should be
> separated.  If they share enough code (I haven't looked closely) to
> warrant being in the same file, they should still have #ifdefs to
> allow individual selection.

Actually most of the chunks are the same, only some extra chunks apply
to each newer incarnation. I wouldnt hack around with ifdefs. Actually I
dont think more than 0.5% of ffmpeg users will need FLC/FLX/DTA
encoders, thus they could disable the whole thing.

> The decoder can be renamed to flicdec.c separately.

You mean svn move?

--
Alex Beregszaszi