[Ffmpeg-devel] [PATCH] HD DVD subtitle decoding

Michael Niedermayer michaelni
Mon Feb 19 13:07:37 CET 2007


On Mon, Feb 19, 2007 at 10:48:35AM +0000, Ian Caulfield wrote:
> On 18/02/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >Hi
> >iam more in favor of putting the YUV_TO_RGB*_CCIR into a header and
> >including this
> >what the function above does seems quite specific to dvdsubdec.c
> >so IMHO it should be there rather
> I think dvbsubdec does a yuv->rgb conversion in more or less the same
> way. I'll move the code over to a separate header (colorspace.h?)

if you keep the loop in dvdsubdec.c then moving YUV_TO_RGB*_CCIR to
colorspace.h sounds like a good idea

if OTOH you want the loop itself in a common file then you will
have to put that in libswscale and write a efficient general propose
yuv444(planar) -> rgb32 conversation function
(do not put it in libswscale/yuv2rgb.c as that is GPL) 
this is of course more work then moving the YUV_TO_RGB*_CCIR to a
common header but might also come in handy for other things ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070219/b5b627e3/attachment.pgp>

More information about the ffmpeg-devel mailing list