[Ffmpeg-devel] xprintf cleanup: wma.c

Michael Niedermayer michaelni
Mon Feb 19 22:44:03 CET 2007


On Mon, Feb 19, 2007 at 02:28:20PM +0100, Michel Bardiaux wrote:
> It contains 1 first dprintf
>     dprintf("flags1=0x%x flags2=0x%x\n", flags1, flags2);
> that is probably a relic since there are no such variables visible.

if there are no such vars remove the dprintf

> The following dprintf can easily become av_log.
> The 2nd #if around the tprintf can go away since tprintf is a nop anyway 
> when TRACE is not defined.

theres a for loop in it ...

> The 1st one is an #if 0 hence a question mark: keep or zorch?

not my code, and fabrice wont awnser (iam 99.99% sure about that ...)

> tprintf itself is also a question. It uses av_log(NULL, which is bad. 
> One coulddo one of the following:
> * Change all tprintf to av_log(VERBOSE) (or DEBUG)
> * Add a context argument to tprintf, but keep it a nop when TRACE not 
> defined.

i like giving trpintf a context ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070219/a338f2d4/attachment.pgp>

More information about the ffmpeg-devel mailing list