[Ffmpeg-devel] [PATCH] av_log Doxygen docs
Tue Feb 20 11:25:19 CET 2007
-----BEGIN PGP SIGNED MESSAGE-----
Michael Niedermayer schreef:
> On Tue, Feb 20, 2007 at 10:02:56AM +0100, Panagiotis Issaris wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> Michael Niedermayer schreef:
>>> On Mon, Feb 19, 2007 at 07:29:17PM +0100, Panagiotis Issaris wrote:
>>>>>> + * av_log_level. By default, all logging messages are sent to
>>>>>> stderr. This
>>>>>> + * behavior can be altered by setting a different av_vlog callback
>>>>>> + *
>>>>>> + * @param avcl The AVClass which provides context for the message
>>>>> No, you pass the address of any structure which has an AVClass* as
>>>>> first field. Currently, an AVCodecContext* or AVFormatContext*.
>>>> Oh, I figured it was a bit OO-inheritance like and had shortened the
>>>> following into the above:
>>>> "The instance of AVClass which provides the context for the message."
>>>> Do you agree with the unshortened version, or do you think the
>>>> shortening was not the problem?
>>> avc1 is a pointer to a pointer to a AVClass
>>> or avc1 is a pointer to an arbitrary struct whos first field is a pointer to
>>> a AVClass struct
>>> or in OOshit talk avc1 is a pointer to an instance of a subclass of a class
>>> which contains exactly one field, and this field is a pointer to a AVClass
>>> all the same just getting more obfuscated as you get closer to CS dreamland
>> Here's an updated patch using the imho clearest description (the second).
>> + * Send the specified message to the log if the level is higher than or equal to
>> + * the current av_log_level. By default, all logging messages are sent to
>> + * @param level The importance level of the message, lower values signifying
>> + * higher importance.
> lower is more important but level >= av_log_level is sent ? this cant be
No, I think level <= av_log_level is sent.
With friendly regards,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the ffmpeg-devel