[Ffmpeg-devel] [PATCH] av_log Doxygen docs

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Panagiotis Issaris schreef:
> Michel Bardiaux schreef:
>> Panagiotis Issaris wrote:
>> [snip]
>>>>> Here's an updated patch using the imho clearest description (the
>>>>> second).
>>>> [...]
>>>>> + * Send the specified message to the log if the level is higher
>>>>> than or equal to
>>>>> + * the current av_log_level. By default, all logging messages are
>>>>> sent to
>>>> [...]
>>>>> + * @param level The importance level of the message, lower values
>>>>> signifying
>>>>> + * higher importance.
>>>> [...]
>>>>
>>>> lower is more important but level >= av_log_level is sent ? this cant be
>>>> correct
>>> No, I think level <= av_log_level is sent.
>>>
>>> libavutil/log.c:
>>>     35     if(level>av_log_level)
>>>     36         return;
>> Aargh, sorry, I gave wrong indications. It is indeed "if the level is
>> less than or equal to...".
> 
> 
> I'm all confused now :)
> 
> To me it seems that ... oh I see now. The remark was about the general
> function's explanation not the @param level option...
> 
>      31 void av_log_default_callback(void* ptr, int level, ...
>      32 {
>      33     static int print_prefix=1;
>      34     AVClass* avc= ptr ? *(AVClass**)ptr : NULL;
>      35     if(level>av_log_level)
>      36         return;
> 
> I'll send a patch in a second.
Here it is.

 log.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

With friendly regards,
Takis
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF2tAc9kOxLuzz4CkRAth1AJ4+DBaL2l4CffPoQ8q0aWhsvqQS8QCfVRWS
NHTiuq0kSx56fAyiFrllKpA=
=P0XN
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070220T113916-ffmpeg-av_log_dox4.diff
Type: text/x-patch
Size: 964 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/d3119980/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070220T113916-ffmpeg-av_log_dox4.diff.sig
Type: application/octet-stream
Size: 65 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/d3119980/attachment.obj>