[Ffmpeg-devel] xprintf cleanup: wma.c

Michael Niedermayer michaelni
Tue Feb 20 18:18:17 CET 2007


On Tue, Feb 20, 2007 at 04:00:13PM +0100, Michel Bardiaux wrote:
> >>tprintf itself is also a question. It uses av_log(NULL, which is bad. 
> >>One coulddo one of the following:
> >>
> >>* Change all tprintf to av_log(VERBOSE) (or DEBUG)
> >>
> >>* Add a context argument to tprintf, but keep it a nop when TRACE not 
> >>defined.
> >
> >i like giving trpintf a context ...
> >
> I agree. Now, I would rather not have to change all the calls at the 
> same time (and you probably prefer not to have to review such a monster 
> change!), so I propose adding a tprintfext function, then progressively 
> removing all the tprintf.

just give all tprintf a context, i dont mind the size of the patch it should
be easy to review as it contains only very trivial changes

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/2751e0b8/attachment.pgp>

More information about the ffmpeg-devel mailing list