[Ffmpeg-devel] [PATCH] Remove INT64_C from "common.h"

Måns Rullgård mans
Sun Feb 25 20:26:37 CET 2007


"Alexander Chemeris" <ipse.ffmpeg at gmail.com> writes:

> On 2/24/07, M?ns Rullg?rd <mans at mansr.com> wrote:
>> angustia at arrozcru.no-ip.org writes:
>>
>> > Quoting Alexander Chemeris <ipse.ffmpeg at gmail.com>:
>> >
>> >> Hello,
>> >>
>> >> INT64_C macro is defined in <stdint.h>, according to paragraph 7.18.4.1
>> >> of C99 standard. I belive it should be removed from "common.h" include,
>> >> because it is system dependent. E.g. under MS Visual Studio it should
>> >> be defined as
>> >>
>> >> #define INT64_C(val) val##i64
>> >>
>> >
>> > Simply ignored? I thought you people wanted the "ffmpeg only builds
>> > with gcc" statement to be false...
>> >
>> > Leaving that there might "just happen to work" on systems that don't
>> > define INT64_C.
>>
>> I don't mind removing it.
>>
> GCC does not have this macro definition?
> Else I do not see any reasons for this patch to be rejected. Only
> non-technical negligence. You're so inconsistent here.

It's standard C99.  I overlooked it during some cleanup a while back.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list