[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Michael Niedermayer]

Hi

On Mon, Feb 26, 2007 at 09:23:08AM +0100, Benoit Fouet wrote:
> Hi,
> 
> Benoit Fouet wrote:
> > Hi,
> >
> > Michael Niedermayer wrote:
> >   
> >> Hi
> >>   
> >> well the user could then set -ab Y -vb X
> >> if he says -b it means all bitrates so its logic to well set all
> >> sure it changes behavior and iam not sure its the best solution but 
> >> IMHO its more consistant to prefix video by v when audio is prefixed by a
> >>
> >>   
> >>     
> > in that case, i agree...
> > we will need to have new options though.
> > if it is ok, then a first patch could be sent, which just splits
> > avctx_opts to a table of contexts, and ensure the functionning is the
> > same as before...
> > then we could look at adding prefixed options (and remove audio specific
> > stuff such as ar, ab, ...)
> >
> >   
> is something like the attached could suit ?

yes


[...]
> and when we change options, we'll also need to change regression tests
> script too, i guess...

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070226/85f59c96/attachment.pgp>