[Ffmpeg-devel] [RFC] bytestream show and change

Michael Niedermayer michaelni
Fri Jan 5 01:42:47 CET 2007


Hi

On Thu, Jan 04, 2007 at 11:50:49PM +0100, Alex Beregszaszi wrote:
> Hi,
> 
> > > If I got this right, I will implement it now.
> 
> This way?

yes

though maybe

#if 1 //benchmark on your architecture and update this #if
#define AV_RB32(x) ((((uint8_t*)(x))[0] << 24) | \
                    (((uint8_t*)(x))[1] << 16) | \
                    (((uint8_t*)(x))[2] << 8) | \
                     ((uint8_t*)(x))[3])
#else
#define AV_RB32(x) le2me_16(LD32(x))
#endif

would be better

also i think that a few more () are needed in the macros

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070105/4c34175a/attachment.pgp>



More information about the ffmpeg-devel mailing list