[Ffmpeg-devel] [PATCH] Optimization of 'dct_unquantize_h263_intra' for ARM (armv5te) (try2)

Siarhei Siamashka siarhei.siamashka
Sat Jan 6 22:59:51 CET 2007


On Saturday 06 January 2007 23:34, Diego Biurrun wrote:

> On Sat, Jan 06, 2007 at 06:07:53PM +0200, Siarhei Siamashka wrote:
> > --- libavcodec/armv4l/mpegvideo_armv5te.c	(revision 0)
> > +++ libavcodec/armv4l/mpegvideo_armv5te.c	(revision 0)
> > @@ -0,0 +1,211 @@
> > +/*
> > + * The simplest mpeg encoder (well, it was the simplest!)
>
> Is this a complete MPEG encoder?  It seems to me this comment is plain
> wrong.
>
> > + * Copyright (c) 2000,2001 Fabrice Bellard.
> > + * Copyright (c) 2002-2004 Michael Niedermayer <michaelni at gmx.at>
>
> I'd rather say that your name and the year 2007 belongs there.

Sure, license was copied from mpegvideo.c as this code is entirely based on
it. I only did the job of a codegenerator translating from C to ARM assembly 
(and also using some other additional information to optimize). I would not
claim full copyright on this code.

Also some other people may want to add optimizations for other functions, such
as dct_unquantize_mpeg1_* and dct_unquantize_mpeg2_*, so they would need
to add their copyright somewhere.

So what should I do to fix this copyright information properly?




More information about the ffmpeg-devel mailing list