[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding

Diego Biurrun diego
Sun Jan 7 22:52:43 CET 2007

On Sun, Jan 07, 2007 at 08:54:13PM +0000, Paul Richards wrote:
> On 07/01/07, Paul Richards <paul.richards at gmail.com> wrote:
> >After taking in the various comments given here is the revised patch.
> >Perhaps it can be considered for committing.
> >
> >Unfortunately the VLC playback problem remains but I cannot yet
> >identify the source of the problem.  Hopefully this can be resolved in
> >a followup commit.
> Here is another attempt.  This time I have refactored code which
> checks libtheora return values.
> Hopefully this one is good enough to commit? :p

You still have trailing whitespace in the file and it has not been
renamed to libtheoraenc yet.  Also, please respect alphabetical order in
the configure script.


More information about the ffmpeg-devel mailing list