[Ffmpeg-devel] [PATCH] Optimization of 'dct_unquantize_h263_intra' for ARM (armv5te) (try2)

Michael Niedermayer michaelni
Sun Jan 7 23:16:38 CET 2007


On Mon, Jan 08, 2007 at 12:03:41AM +0200, Siarhei Siamashka wrote:
> > > +/* GCC 3.1 or higher is required to support symbolic names in assembly
> > > code */ +#if (__GNUC__ > 3) || ((__GNUC__ == 3) && (__GNUC_MINOR__ >= 1))
> >
> > i assume theres no platform with arm and only gcc 2.95 ?
> I asked this question on #oe channel at irc.freenode.net and got information
> that some images for Sharp Zaurus still use gcc 2.95, so it is better to keep
> this ifdef. But anyway, most of linux handhelds are using up to date versions
> of gcc.

the ifdef has to be kept either way, what my concern is and was is that your
code might not be useable on a "significant" number of platforms (= i would
have preferred if it would have been written without named operands so that
it could be used with more compilers ...)
thats no reason to reject its just not ideal ...

> On Sunday 07 January 2007 01:08, Diego Biurrun wrote:
> > State what the file does, i.e. provide optimized functions for MPEG
> > decoding or encoding.  Add your name with a copyright year and say what
> > it is based on, possibly with some more copyright statements.
> OK, changed copyright header a bit. Maybe it is better now.
> Also added references to some docs (ARM architecture reference manual, and
> optimization guide for ARM9E) which may be interesting for those who would 
> like to work on ARM optimizations, or just may want to check existing asm
> code. It took me a while to find this documentation, so it may be useful
> to have these references in comments.

these could be added to doc/optimization.txt

and patch ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No evil is honorable: but death is honorable; therefore death is not evil.
-- Citium Zeno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070107/c1797fee/attachment.pgp>

More information about the ffmpeg-devel mailing list