[Ffmpeg-devel] FFmpeg API Discrepancies

Michael Niedermayer michaelni
Tue Jan 9 12:32:04 CET 2007


On Mon, Jan 08, 2007 at 06:26:40PM -0800, Roman Shaposhnik wrote:
> On Mon, 2007-01-08 at 17:19 -0800, Mike Melanson wrote:
> > Questions from a xine co-dev...
> > 
> > 
> > am i rightly assuming that dv.c is buggy because it doesn't call
> > release_buffer() on dvvideo_close()?
>   I'm not sure I understand the intricate details of buffer management
> well enough but it looks like lots of codecs are that way -- they
> do: 
>     if(s->picture.data[0])
>         avctx->release_buffer(avctx, &s->picture);
> in the context of *_decode_frame() and they don't (are not supposed to?)
> care about *_close().
>   Am I missing something here ?

some codes do release_buffer() during close (all mpeg and h26* codecs IIRC)
i dont think its documented anywhere if this is needed or not but looking
at the analogy of malloc() and free() id say things which have been allocated
should be freed ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070109/239cb06b/attachment.pgp>

More information about the ffmpeg-devel mailing list