[Ffmpeg-devel] Bug? Subtitles not detected in vob
Wed Jan 10 18:37:59 CET 2007
On Wed, Jan 10, 2007 at 04:44:58PM -0000, Wolfram Gloger wrote:
> > well if you call av_estimate_timings at 80% of a file it would with
> > your change estimate the bitrate and duration based on the last 20% or?
> > now seek back to the start, maybe the seek code ignores duration and
> > start time but thats not guranteed and actually the seek code should
> > use the duration and start time instead of redoing the estimation ...
> Agreed. I keep getting mixed up between av_find_stream_info and
> av_estimate_timings. av_estimate_timings really just computes two
> global stream parameters (start_time and duration) and that certainly
> should cover the whole file.
> However, I would argue for av_find_stream_info to be callable anywhere
> within the stream (as it can return significantly different parameters
> eg. in MPEG-TS), and since it calls av_estimate_timings()...
yes, what bad happens if av_find_stream_info() returns local info but
> > > Although this does not affect the issue at hand (just checked), I
> > > would propose this change also because it makes av_estimate_timings
> > > more generic (i.e. it can be called after seeking).
> > i think iam fine with this change
> ...so here that change without further side-effects.
> --- trunk/libavformat/utils.c Mon Jan 8 16:01:14 2007
> +++ ffmpeg/libavformat/utils.c Wed Jan 10 17:39:27 2007
> @@ -1561,6 +1561,7 @@
> int read_size, i, ret;
> int64_t end_time;
> int64_t filesize, offset, duration;
> + offset_t old_offset;
> /* free previous packet */
> if (ic->cur_st && ic->cur_st->parser)
> @@ -1580,6 +1581,7 @@
> /* we read the first packets to get the first PTS (not fully
> accurate, but it is enough now) */
> + old_offset = url_fseek(&ic->pb, 0, SEEK_CUR);
change that to url_ftell() and iam happy with the patch
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No evil is honorable: but death is honorable; therefore death is not evil.
-- Citium Zeno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel