[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding

Paul Richards paul.richards
Thu Jan 11 22:38:04 CET 2007


On 10/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> Please don't top-post.
>
> On Mon, Jan 08, 2007 at 09:20:19AM +0000, Paul Richards wrote:
> >
> > On 07/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> > >On Sun, Jan 07, 2007 at 08:54:13PM +0000, Paul Richards wrote:
> > >> On 07/01/07, Paul Richards <paul.richards at gmail.com> wrote:
> > >> >After taking in the various comments given here is the revised patch.
> > >> >Perhaps it can be considered for committing.
> > >> >
> > >> >Unfortunately the VLC playback problem remains but I cannot yet
> > >> >identify the source of the problem.  Hopefully this can be resolved in
> > >> >a followup commit.
> > >>
> > >> Here is another attempt.  This time I have refactored code which
> > >> checks libtheora return values.
> > >>
> > >> Hopefully this one is good enough to commit? :p
> > >
> > >You still have trailing whitespace in the file and it has not been
> > >renamed to libtheoraenc yet.  Also, please respect alphabetical order in
> > >the configure script.
> >
> > Here are the file rename, whitespace, and ordering changes you requested.
>
> Trailing whitespace is still there.  Please call the configure option
> --enable-libtheora.  Also, I reordered libavcodec/Makefile and put the
> external libraries in a separate block, libtheora should go there.
>
> The following block is an independent change that should go in right
> away I think:
>
[snip]

I previously only removed the trailing newlines at the very end.  I
didn't realise that trailing whitespace internal to the file was what
you meant.  This is now fixed, as well as renaming the '--enable' flag
and the libavcodec/Makefile ordering.


-- 
Paul Richards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora.patch
Type: application/octet-stream
Size: 13166 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070111/05b30c6c/attachment.obj>



More information about the ffmpeg-devel mailing list