[Ffmpeg-devel] [PATCH] Musepack out of bounds accesses
Sun Jan 14 06:55:20 CET 2007
On Sat, Jan 13, 2007 at 04:43:28PM +0100, Reimar D?ffinger wrote:
> attached patch fixes two such.
> First is in the demuxer during playback-index-building, there is no check that the
> index array is large enough. It would be possible to realloc it, but I'm
> not sure if that's such a good idea, thinking e.g. of doing streaming
> (esp. since I think it does not respect noidx?).
I don't think it's right solution - maybe that frame should not be passed at all.
Try to change condition at line 121 and check what happens.
> The other one is because the decoder does not provide the padding the
> bitstream reader needs.
This patch is fine to me, apply anytime.
> First issues regularly causes crashes at end of playback for my files
> (and someone else's on Windows, too).
> Reimar D?ffinger
More information about the ffmpeg-devel