[Ffmpeg-devel] [PATCH] waveformatetensible support

Michael Niedermayer michaelni
Mon Jan 15 00:05:20 CET 2007


Hi

On Sun, Jan 14, 2007 at 10:44:34PM +0100, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sun, Jan 14, 2007 at 01:51:29PM +0100, Baptiste Coudurier wrote:
> >> Hi
> >>
> >> Michael Niedermayer wrote:
> >>> Hi
> >>>
> >>> On Sun, Jan 14, 2007 at 01:39:27AM +0100, Baptiste Coudurier wrote:
> >>>> Hi
> >>>>
> >>>> Here is a patch to support waveformatextensible header.
> >>>> Only four first byte of GUID are needed, and they seem to match twocc.
> >>> [...]
> >>>
> >>> cosmetics must be in seperate patches
> >>>
> >> Ok. Here it is.
> > 
> > [...]
> > 
> >> -    codec->codec_id = wav_codec_get_id(id, codec->bits_per_sample);
> >> -
> >>      if (size > 16) {  /* We're obviously dealing with WAVEFORMATEX */
> >> -        codec->extradata_size = get_le16(pb);
> >> +        int cbSize = get_le16(pb);
> >> +        if (id == 0xfffe) {
> >> +            codec->bits_per_sample = get_le16(pb);
> >> +            get_le32(pb); /* dwChannelMask */
> >> +            id = get_le32(pb); /* 4 first bytes of GUID */
> >> +            cbSize = 10; /* skip remaining bytes */
> > 
> > why? why not read them in extradata?
> > 
> 
> What would you do with 12 last bytes of GUID in extradata ?

nothing but maybe i want the 13th and later bytes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070115/6613d748/attachment.pgp>



More information about the ffmpeg-devel mailing list