[Ffmpeg-devel] [PATCH] do not probe AVFMT_NOFILE formats if file is already opened

Michael Niedermayer michaelni
Fri Jan 19 00:20:22 CET 2007


On Thu, Jan 18, 2007 at 12:39:06PM +0100, Reimar D?ffinger wrote:
> Hello,
> I am not sure about the supposed behaviour, but currently when calling
> av_probe_input_format with is_opened == 1 the img2 demuxer will try to
> substitute %d and open the resulting file names.
> IMO it would be more desirable (and fixes a crash with mplayer) not to
> try any demuxers that will open a file when is_opened == 1, as attached
> patch does.

if this patch doesnt break anything then iam fine with it

> Also, after deciding about the supposed semantics, I would propose renaming
> AVFMT_NOFILE to something that gives at least some hint about what it is
> supposed to mean, the comment for it is just as stupid: "/* no file
> should be opened */" well, obviously somewhen a "file" must be opened, so
> is the comment supposed to mean no file should be opened by the caller,
> or by the demuxer or...

id rather change the comment then the identifer which breaks compatibility

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070119/07b097e3/attachment.pgp>

More information about the ffmpeg-devel mailing list