[Ffmpeg-devel] [PATCH] a fix in ffmpeg.c

Michael Niedermayer michaelni
Fri Jan 19 11:29:43 CET 2007


On Fri, Jan 19, 2007 at 11:16:52AM +0800, Limin Wang wrote:
> Hi Michael,
> The real cause is video_sync_method is enable default, so if the h264
> video pts isn't set with real value, ffmpeg.c:709 will get vdelta < -1.1,
> and will cause some frames dropped. How about fixing it in utils.c?
> Please review it.

this looks better but it still has problems
first it overrides the demuxer timebase blindly, which breaks some
h264 in avi/mov, also it breaks user specified timebases 
(ffmpeg -r 12 myfile.h264 out.abc)

so the check should not be for CODEC_ID_H264 but rather for the lack of
a set timebase (this needs some change to libavformat/raw.c more specifically
the hardcoded 1/25 timebase there should be changed to 0/0) then utils.c
somewhere should check for this and set it to the codec timebase
st->codec->time_base with av_set_pts_info or if that also is 0/0 then 
use some random default like 1/25

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070119/2f8c61b8/attachment.pgp>

More information about the ffmpeg-devel mailing list