[Ffmpeg-devel] [PATCH] install libavformat/riff.h

Michael Niedermayer michaelni
Sun Jan 21 01:48:29 CET 2007


On Sat, Jan 20, 2007 at 10:31:40PM +0100, Nico Sabbi wrote:
> Michael Niedermayer wrote:
> >
> >nico, just give the ones mplayer needs an av_ prefix and move them to
> >avformat.h or split riff.h into riff.h+riff_internal.h
> >
> >
> let's see: I'd move to riff_internal.h
> offset_t start_tag(ByteIOContext *pb, const char *tag);
> void end_tag(ByteIOContext *pb, offset_t start);
> void put_bmp_header(ByteIOContext *pb, AVCodecContext *enc, const 
> CodecTag *tags, int for_asf);
> int put_wav_header(ByteIOContext *pb, AVCodecContext *enc);
> int wav_codec_get_id(unsigned int tag, int bps);
> void get_wav_header(ByteIOContext *pb, AVCodecContext *codec, int size);
> and to riff.h (prepended by ff_):

av_ prefix ...

anyway ive thought about this a little and ill fix it myself
ill add several codec_tag=int<->codec_id=int lists to the AVIn/OutputFormat
and export nice functions which can map between them AVCodecTag 
(codec_tag, codec_id currently like CodecTag without invalid_asf) will be
an opaque struct so user apps wont become dependant on its details

to get the best codec tag for asf you could then do
av_codec_get_tag(asf_muxer.codec_tag, codec_id);

comments welcome but be quick as ill probably have this finished and
in svn in a few hours ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070121/0b155a64/attachment.pgp>

More information about the ffmpeg-devel mailing list