[Ffmpeg-devel] use of uninitalized variables in libavcodec/truemotion1.c

Michael Niedermayer michaelni
Mon Jan 22 18:27:14 CET 2007


On Mon, Jan 22, 2007 at 11:26:49AM +0100, Sascha Sommer wrote:
> Hi,
> in line 377 of libavcodec/truemotion1.c in truemotion_decode_header()
> there is
>     if (s->flags & FLAG_SPRITE) {
>         av_log(s->avctx, AV_LOG_INFO, "SPRITE frame found, please report the 
> sample to the developers\n");
>         s->w = header.width;
>         s->h = header.height;
>         s->x = header.xoffset;
>         s->y = header.yoffset;
> However none of these header.* variables have been initialized before.
> Shouldn't the function return -1 like it does for other headers when these 
> SPRITE frames are found?

yes, id suggest you post a patch which does that with a 
"will apply in a few days" warning and if the maintainer doesnt reply
then just apply your own patch in a few days ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070122/5e54a72e/attachment.pgp>

More information about the ffmpeg-devel mailing list