[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding
Tue Jan 23 15:55:59 CET 2007
On Mon, Jan 22, 2007 at 03:16:30PM +0000, Paul Richards wrote:
> On 21/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> >On Sun, Jan 21, 2007 at 09:53:47PM +0000, Paul Richards wrote:
> >> These issues have been addressed.
> >> --- libavcodec/allcodecs.c (revision 7612)
> >> +++ libavcodec/allcodecs.c (working copy)
> >> @@ -200,6 +200,9 @@
> >> +#ifdef CONFIG_LIBTHEORA
> >> + REGISTER_ENCODER(LIBTHEORA, libtheora);
> >> +#endif
> >These are no longer necessary, Mans came up with a system for moving
> >dependency detection to configure, you'll have to add a line there, look
> >at what is done for oggvorbis/libvorbis.
> >> --- libavcodec/avcodec.h (revision 7612)
> >> +++ libavcodec/avcodec.h (working copy)
> >> @@ -2160,6 +2160,7 @@
> >> extern AVCodec mjpeg_encoder;
> >> +extern AVCodec libtheora_encoder;
> >> extern AVCodec ljpeg_encoder;
> >Please put these in alphabetical order.
[configure, makefile and related stuff i dont maintain]
> +/* libtheora includes */
> +#include "theora/theora.h"
shouldnt that rather be <theora/theora.h> ?
> + avc_context->extradata_size = 0;
> + avc_context->extradata = 0;
these arent needed
except these iam fine with the patch
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel