[Ffmpeg-devel] [PATCH]BMP encoder

Michael Niedermayer michaelni
Wed Jan 24 00:56:03 CET 2007


On Tue, Jan 23, 2007 at 03:33:52PM +0100, Alex Beregszaszi wrote:
> Hi,
> > +#define read16(bits) bswap_16(get_bits(bits, 16))
> > +#define read32(bits) bswap_32(get_bits_long(bits, 32))
> ...
> > +#define write16(bits, val) put_bits(bits, 16, bswap_16(val))
> > +#define write32(bits, val) put_bits(bits, 32, bswap_32(val))
> What about using bytestream.h or intreadwrite.h instead this? I dont see
> its putting/reading non-8bit aligned data:

no objections feel free to send a patch after this has been applied
but note ill reject it if bmp.o becomes larger (speed is irrelevant, only
size and readability matters for this code)
i also suspect changing the #define to a static func() would be a good
idea ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070124/510a0e79/attachment.pgp>

More information about the ffmpeg-devel mailing list