[Ffmpeg-devel] [PATCH] Reduce number of warnings in snow.c

Panagiotis Issaris takis.issaris
Wed Jan 24 15:10:32 CET 2007


The attached patch brings the number of warnings from 33 to 16 by:
- explicitly using braces in some cases, namely when GCC suggests:
  * suggest parentheses around + or - inside shift
  * suggest parentheses around && within ||
- using the const keyword ("initialization discards qualifiers from
pointer target type")

 snow.c |   54 +++++++++++++++++++++++++++---------------------------
 1 file changed, 27 insertions(+), 27 deletions(-)

Patch is not really needed, and some might argue that GCC is wrong
suggesting this, but, the extra parentheses can't do harm, and they make
it easier to focus on the true errors (when I'm doing the MpegEncContext

With friendly regards,
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070124T145503-ffmpeg-snow_casts.diff
Type: text/x-patch
Size: 6292 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070124/e241f83f/attachment.bin>

More information about the ffmpeg-devel mailing list