[Ffmpeg-devel] [PATCH]BMP encoder

Aurelien Jacobs aurel
Wed Jan 24 23:06:37 CET 2007


On Wed, 24 Jan 2007 15:16:18 +0100
Michel Bardiaux <mbardiaux at mediaxim.be> wrote:

> M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > [...]
> > 
> >> better put the encoder into its own file
> > 
> > Yes, please.
> 
> OK, I will. That implies moving the BMP_RLE4 etc to a bmp.h, and 
> BMPContext. What should I do about the _init method? One for enc and one 
> for dec, even if that duplicates the code?

Idealy you could `svn mv bmp.c bmpdec.c` then create a new bmp.c file
containing common code for encoder and decoder (with proper declarations
in bmp.h).
But it may be overkill in this situation, and maybe duplicating this
2 lines _init function is ok ?

Aurel




More information about the ffmpeg-devel mailing list