[Ffmpeg-devel] [PATCH] Portable snprintf argument for http.c

Michael Niedermayer michaelni
Thu Jan 25 00:48:26 CET 2007


Hi

On Wed, Jan 24, 2007 at 08:22:57PM +0000, M?ns Rullg?rd wrote:
> ramiro at lisha.ufsc.br writes:
> 
> > Hello,
> >
> > Attached patch uses the portable PRIu64 argument for snprintf in http.c

looks ok


> >
> > Ramiro Polla
> >
> > Index: libavformat/http.c
> > ===================================================================
> > --- libavformat/http.c	(revision 7692)
> > +++ libavformat/http.c	(working copy)
> > @@ -222,7 +222,7 @@
> >               "%s %s HTTP/1.1\r\n"
> >               "User-Agent: %s\r\n"
> >               "Accept: */*\r\n"
> > -             "Range: bytes=%llu-\r\n"
> > +             "Range: bytes=%"PRIu64"-\r\n"
> >               "Host: %s\r\n"
> >               "Authorization: Basic %s\r\n"
> >               "\r\n",
> 
> The argument is signed...

indeed but thats a seperate issue the llu->PRIu64 patch shouldnt change
the signedness of the thing

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No evil is honorable: but death is honorable; therefore death is not evil.
-- Citium Zeno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070125/a69edd53/attachment.pgp>



More information about the ffmpeg-devel mailing list