[FFmpeg-devel] [PATCH] ffmpeg.c -me option implemented as an AVOption

[Stefano Sabatini]

On date Thursday 2007-07-05 20:24:49 +0200, Michael Niedermayer encoded:
> Hi
> 
> On Thu, Jul 05, 2007 at 03:12:56PM +0200, Stefano Sabatini wrote:
[...]
> > One problem is that the patch is *not backward compatile*, since it
> > changes the OptionDef option "me" with the predefined "me_method"
> > AVOption defined in libavcodec/utils.c.
> > 
> > If you think this is a problem I can modify the patch in order to
> > support the old option name with something as:
> > 
> > {"me", "set motion estimation method (deprecated, use me_method insted)", 
> >  OFFSET(me_method), FF_OPT_TYPE_INT, ME_EPZS, INT_MIN, INT_MAX, V|E, "me_method"},
> > 
> > in libavcodec/utils.c:options.
> 
> yes, please add this but under #if LIBAVCODEC_VERSION_INT < ... so that it
> automatically disapears with the next major version bump

Done, hope it is OK.

> > BTW: I noted that there are many OptionDef options in ffmpeg.c which
> > can be implemented as AVOptions ones, resulting in simpler code. Is it
> > OK to change them in this way too?
> 
> yes (note dont forget the regression tests)

OK (patches incoming...) ;-).

But before I want to manage this (obviously into another thread):
sds at santefisi:~/tmp$ ffmpeg -b bogus
[...]
ffmpeg: unrecognized option '-b'

Cheers.
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: me-method-as-avoption-01.patch
Type: text/x-diff
Size: 5763 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070705/aa7be37b/attachment.patch>