[FFmpeg-devel] [PATCH] moves ff_set_mpeg4_time to mpegvideo_enc.c

Michael Niedermayer michaelni
Fri Jul 6 10:44:55 CEST 2007


On Fri, Jul 06, 2007 at 01:51:20AM +0200, Aurelien Jacobs wrote:
> Hi,
> The attached patch moves ff_set_mpeg4_time to mpegvideo_enc.c because
> it is only used by this file. This allows to make the function static.
> Moreover this function is used for mpeg1/2 as well as mpeg4 so it
> definitely don't belong in h263.c and it really deserve a renaming
> (as suggested by the FIXME comment).
> Is it OK ?

well ...

the function should be split, some of the things are needed for all
b frame encodings some are mpeg4 specific, later belong in h263.c
not mpegvideo*.c unless you split mpeg4 out of h263.c ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070706/932ec608/attachment.pgp>

More information about the ffmpeg-devel mailing list